PB-496: Fix external layer error and time slider issue#858
Merged
Conversation
Passing run #2271 ↗︎
Details:
Review all test suite changes for PR #858 ↗︎ |
|||||||||||||||
pakb
reviewed
May 23, 2024
src/store/modules/layers.store.js
Outdated
| // Here we cannot take the getter visibleLayers as it also contain the preview and system layers | ||
| state.activeLayers.filter( | ||
| (layer) => layer.visible && layer.timeConfig?.timeEntries?.length | ||
| (layer) => layer.visible && layer.timeConfig?.timeEntries?.length > 1 |
Contributor
There was a problem hiding this comment.
(layer) => layer.visible && layer.hasMultipleTimestamps would also work fine 😉
9ded642 to
693f14c
Compare
At startup we never know the projection of the external layers, the projection is taken from the capabilities that needs to be loaded first. Therefore don't test projection upon creation and don't do any fallback. Also fixed an issue when a layer has only one timestamp, the time slider was displayed but the user could not change the timestamp.
693f14c to
8617bda
Compare
pakb
approved these changes
May 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At startup we never know the projection of the external layers, the projection
is taken from the capabilities that needs to be loaded first. Therefore don't
test projection upon creation and don't do any fallback.
Also fixed an issue when a layer has only one timestamp, the time slider was
displayed but the user could not change the timestamp.
Test link