Merged
Conversation
Passing run #2283 ↗︎
Details:
Review all test suite changes for PR #857 ↗︎ |
|||||||||||||||
Currently on Cesium changing the year is removing/adding the layer which is not so nice when using the slider play feature as it result to a flickering effect. The way Cesium is configured don't allow us to do layer update. It seems that we could do it with a state management system but would required a big rewrite of 3D.
a87d7c6 to
dd75dc6
Compare
pakb
approved these changes
May 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently on Cesium changing the year is removing/adding the layer which
is not so nice when using the slider play feature as it result to a flickering
effect.
The way Cesium is configured don't allow us to do layer update. It seems that
we could do it with a state management system but would required a big rewrite
of 3D.
Test link