PB-530: Added print date to the print API spec#854
Conversation
Passing run #2260 ↗︎
Details:
Review all test suite changes for PR #854 ↗︎ |
|||||||||||||||
There was a problem hiding this comment.
I'm not sure we shouldn't be sending a proper ISO-8601 datestring instead, while testing and looking at what was sent and then received I see some timezone issue.
I started a job with a date sent that was "printDate": "5/23/2024, 8:20 AM" but the file I received in return had Printed on 23.05.2024 06:20 (so the GMT+2 delta)
Have you tested sending a full ISO string ?
Thats because the backend has not been built and deployed yet see https://github.com/geoadmin/service-print3/pull/37, once the backend is deployed it will print what it gets. Now it print its UTC time, which would not be correct if the user is in US he will get utc time and not us time, that's why I want to let the frontend decide on the date and date format. |
pakb
left a comment
There was a problem hiding this comment.
Then all good, maybe we should wait for the PR on the backend side to be merged/deployed, then test the result here, and merge when we are happy with what we see
|
Tested with the new backend deployment and looks good |
Use the date formatting based on the locale (en => MM/DD/YYYY, H:MM PM/AM, fr-CH => DD.MM.YYYY, HH:MM
0a7cb4f to
1c0ee7b
Compare
Use the date formatting based on the locale (en => MM/DD/YYYY, H:MM PM/AM, fr-CH => DD.MM.YYYY, HH:MM
Test link