PB-531: Improve report a problem error management for big files#852
Merged
PB-531: Improve report a problem error management for big files#852
Conversation
Passing run #2263 ↗︎
Details:
Review all test suite changes for PR #852 ↗︎ |
|||||||||||||||
29c3153 to
9a0b16f
Compare
pakb
reviewed
May 23, 2024
hansmannj
reviewed
May 23, 2024
hansmannj
approved these changes
May 23, 2024
Member
hansmannj
left a comment
There was a problem hiding this comment.
Thanks for adapting validation and throwing a detailed error message!
LGTM 👍
9a0b16f to
276be4b
Compare
pakb
approved these changes
May 23, 2024
f0de5f6 to
059bda5
Compare
The backend only support attachment up 10MB, above it returns a 413 error. Same for kml it only support kml up to 2MB. So do the validation up front and provide a nice message to the user.
059bda5 to
a4d11df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend only support attachement up 10MB, above it returns a 413 error.
Same for kml it only support kml up to 2MB.
So do the validation up front and provide a nice message to the user.
Test link