PB-518: Fix timeslider flickering and WMS time enabled layer update#849
Merged
PB-518: Fix timeslider flickering and WMS time enabled layer update#849
Conversation
Passing run #2234 ↗︎
Details:
Review all test suite changes for PR #849 ↗︎ |
|||||||||||||||
9eb72b0 to
fad6b8e
Compare
ltkum
approved these changes
May 21, 2024
Contributor
ltkum
left a comment
There was a problem hiding this comment.
One small thing that I would change, but to be fair, it's not that big of a deal
Looks good to me 👍
fad6b8e to
624dd6a
Compare
Now when clicking on play on the time slider the layer is updated and not removed/added which made a flickering effect.
624dd6a to
a3c9bb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now when clicking on play on the time slider the layer is updated and not
removed/added which made a flickering effect.
Also solve the WMS time enabled layer which were not updated upon timestamp changes (via time config or time slider).
NOTE: The time slider flickering effect for 3D mode is not solved with this and cannot be easily solved as apparently Cesium doesn't support to update a layer, or at least I could not find a way.
Test link