PB-449: Removed the modal for report a problem and give feedback#844
Merged
PB-449: Removed the modal for report a problem and give feedback#844
Conversation
Passing run #2156 ↗︎
Details:
Review all test suite changes for PR #844 ↗︎ |
|||||||||||||||
The issue with the modal is that the user loose its content when clicking outside of the modal ! Once the PR #815 is done we can make the window movable.
pakb
approved these changes
May 15, 2024
Contributor
pakb
left a comment
There was a problem hiding this comment.
Saw a little "rest" of the ModalWithBackdrop copy, but that's not really important (if you don't have to rebase, can be let as is)
| default: '', | ||
| }, | ||
| /** | ||
| * Hide the modal with backdrop, can be used to temporarily hide the modal without loosing its |
Contributor
There was a problem hiding this comment.
Technically it's not a "modal with backdrop" anymore, doesn't really matter we understand what this is doing 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue with the modal is that the user loose its content when clicking outside
of the modal !
Once the PR #815 is done we can make the window movable.
Test link