Merged
Conversation
Passing run #2202 ↗︎
Details:
Review all test suite changes for PR #843 ↗︎ |
|||||||||||||||
bd3b618 to
b60c54c
Compare
ltshb
approved these changes
May 21, 2024
5f6c95a to
5a068d5
Compare
5a068d5 to
88606e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old Geoadmin
New Geoadmin
PR Link with sample: https://sys-s.dev.bgdi.ch/9ykglzdf9isf
OL rendering:
Print result:
New and Old Geoadmin with old KML
Sample test film (KML generated from the old geoadmin):
Old Geoadmin link: https://s.geo.admin.ch/psh7bado7148
Print Result
PR link: https://sys-s.dev.bgdi.ch/9vicxy16ethl
https://gist.github.com/ismailsunni/5dba7b0c680de18cd9face7aa3d8df11#file-old-geoadmin-label-kml
OL Rendering
Print result
Remarks: there is still a small offset difference when printing the KML from old geoadmin. I am still couldn't find out where this offset introduced.
Test link