Conversation
Passing run #2144 ↗︎
Details:
Review all test suite changes for PR #842 ↗︎ |
|||||||||||||||
64f0393 to
76a8008
Compare
In production build debug and info messages were printed when they shouldn't
ismailsunni
reviewed
May 15, 2024
Contributor
ismailsunni
left a comment
There was a problem hiding this comment.
LGTM, although I need to re-read to make sure my logic is correct.
I was wondering why not write it as
if (ENVIRONMENT === 'production' && [LogLevel.DEBUG, LogLevel.INFO].includes(level)) {
return
}
Also, in line 21, it says that we only calls with LogLevel.Error, which different compare to the updated code.
pakb
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In production build debug and info messages were printed when they shouldn't
Test link