Skip to content

PB-502: fix topic images absence#838

Merged
ltshb merged 1 commit intodevelopfrom
bugfix-PB-502-topic-images-not-showing
May 14, 2024
Merged

PB-502: fix topic images absence#838
ltshb merged 1 commit intodevelopfrom
bugfix-PB-502-topic-images-not-showing

Conversation

@ltkum
Copy link
Contributor

@ltkum ltkum commented May 14, 2024

Issue : When opening the topic change popover, the images would not show anymore. This was due to the relative link in the css being incorrect.
Fix : We change the relative link to reach the correct location.

Test link

@ltkum ltkum requested review from ltshb and schtibe May 14, 2024 08:18
@github-actions github-actions bot added the bug label May 14, 2024
@cypress
Copy link

cypress bot commented May 14, 2024

Passing run #2121 ↗︎

0 204 20 0 Flakiness 0

Details:

PB-502: fix topic images absence
Project: web-mapviewer Commit: 895806580d
Status: Passed Duration: 05:03 💡
Started: May 14, 2024 9:05 AM Ended: May 14, 2024 9:10 AM

Review all test suite changes for PR #838 ↗︎

@ltkum ltkum force-pushed the bugfix-PB-502-topic-images-not-showing branch 2 times, most recently from 0f7a1f6 to 7d4cc18 Compare May 14, 2024 09:00
Issue : When opening the topic change popover, the images would not show anymore. This was due to the relative link in the css being incorrect.
Fix : We change the relative link to reach the correct location.

Using an absolute link rather than a relative link

link correction
@ltshb ltshb force-pushed the bugfix-PB-502-topic-images-not-showing branch from 7d4cc18 to 8958065 Compare May 14, 2024 09:01
@ltshb ltshb merged commit ae8996e into develop May 14, 2024
@ltshb ltshb deleted the bugfix-PB-502-topic-images-not-showing branch May 14, 2024 09:10
@cypress cypress bot mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants