Skip to content

PB-503: Several UI in menu improvements, especially on mobile#837

Merged
ltshb merged 7 commits intodevelopfrom
bug-icon-size-mobile
May 15, 2024
Merged

PB-503: Several UI in menu improvements, especially on mobile#837
ltshb merged 7 commits intodevelopfrom
bug-icon-size-mobile

Conversation

@ltshb
Copy link
Contributor

@ltshb ltshb commented May 14, 2024

  • Location popup improvement and size fix, it is a bit less condense but it improves the click and text selection on mobile device
    • Before
      image
    • After
      image
  • Language selector and report a problem
    • Before
      image
    • After
      image
  • Input buttons on mobile are now a bit bigger easing their click on touch
    image

Test link

@github-actions github-actions bot added the bug label May 14, 2024
@cypress
Copy link

cypress bot commented May 14, 2024

Passing run #2153 ↗︎

0 204 20 0 Flakiness 0

Details:

Remove useless code
Project: web-mapviewer Commit: 6135a9f32f
Status: Passed Duration: 04:55 💡
Started: May 15, 2024 9:37 AM Ended: May 15, 2024 9:42 AM

Review all test suite changes for PR #837 ↗︎

@ltshb ltshb requested a review from pakb May 14, 2024 09:45
@ltshb ltshb force-pushed the bug-icon-size-mobile branch 2 times, most recently from d6ffe04 to 502f46d Compare May 14, 2024 12:22
@ltshb ltshb requested a review from schtibe May 14, 2024 17:43
ltshb added 7 commits May 15, 2024 11:33
This was an issue as depending on the content the size of the window changed
and moved the arrow.

Also set the tooltip for location share on top to avoid overlapping the
position tab.
Some icons are now bigger on mobile which ease their click on touch device.
Depending on the windows size the language button where shown in the menu as link
instead of button.
@ltshb ltshb force-pushed the bug-icon-size-mobile branch from 502f46d to 6135a9f Compare May 15, 2024 09:33
@ltshb ltshb merged commit 013f6f7 into develop May 15, 2024
@ltshb ltshb deleted the bug-icon-size-mobile branch May 15, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants