PB-486: Fix print area when map is rotated#836
Merged
ismailsunni merged 4 commits intodevelopfrom May 15, 2024
Merged
Conversation
Passing run #2163 ↗︎
Details:
Review all test suite changes for PR #836 ↗︎ |
|||||||||||||||
df65305 to
9aa0811
Compare
ltshb
reviewed
May 14, 2024
Contributor
ltshb
left a comment
There was a problem hiding this comment.
Looks good, just one issue
- Open print menu
- Switch to 3d
- Rotate the map
- Exit 3d
- Go back to print => no print layout
- close print and reopen again => print layer
Maybe force the closing of the print menu when entering 3d.
a76b478 to
cd187e0
Compare
Contributor
Author
|
@ltshb done |
ltshb
approved these changes
May 15, 2024
cd187e0 to
2f29ff9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code from the old geoadmin was working by chance and when there is an internal change in the OpenLayers, it breaks. See the further discussion openlayers/openlayers#15820
Test link