Conversation
Passing run #2174 ↗︎
Details:
Review all test suite changes for PR #835 ↗︎ |
|||||||||||||||
Closed
29e3f8d to
6011278
Compare
3c9040c to
0170eac
Compare
pakb
reviewed
May 15, 2024
pakb
reviewed
May 16, 2024
…and active layers.
facf1f2 to
b4fb976
Compare
pakb
reviewed
May 16, 2024
Contributor
pakb
left a comment
There was a problem hiding this comment.
The height of each element doesn't match between the two, could you shrink the 3D element a little so that it matches the height of the "Map displayed' one?
The 3d menu and geo catalogue menu entries where not the same height as the active menu items due to the missing compact class. Also with the compact class the buttons required the d-flex align-items-center class to be all aligned.
pakb
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link