PB-468 Fix arrow shift of time slider on the edges#833
Conversation
9c7c44c to
24c3dbd
Compare
Passing run #2134 ↗︎
Details:
Review all test suite changes for PR #833 ↗︎ |
|||||||||||||||
4876959 to
bc9b50f
Compare
ltkum
left a comment
There was a problem hiding this comment.
It works quite well, but we encounter an issue where we can reach the end of the slider on the left, but not on the right. The smaller the width, the more visible it is.
After trying it on the current implementation, it looks like this issue is also present, event if it's a lot less visible, since the margins are smaller.
As we are here in the middle of reworking the CSS, it could make sense to change the CSS to be more dynamic (perhaps in another PR). The old mapviewer used a dropdown menu to avoid the issue completely.
That being said, the arrow seem centered and keep being in place. So, this looks good to me.
I'd like to see with @ltshb what we should plan for the CSS issue.
ltshb
left a comment
There was a problem hiding this comment.
Looks good, there are other issues as @ltkum said and also on the right the bar is too long but those issues are not related to this change which makes the bar better.
In my opinion for the issue reported by @ltkum we need to use a dropdown and the issue is only present for very small device, Iphone SE is OK (although for iphone a dropdown could make more sense). The dropdown will be done after go live.
bc9b50f to
b88fb25
Compare
24c3dbd to
6c82677
Compare
The time band was so wide that the cursor was rendered weirdly when dragged to the very end of the time band. Narrowed the band so that the cursor will always have the necessary space to be displayed properly.
6c82677 to
45df54d
Compare
The time band was so wide that the cursor was rendered weirdly when dragged to the very end of the time band:
On suggestion of Brice, I narrowed the band so that the cursor will always have the necessary
space to be displayed properly:
In the process, I also fixed a little display bug, where the arrow wasn't really in the middle of the cursor (or rather, the cursor wasn't centered above the arrow):
Test link