Skip to content

PB-468 Fixed Time-Slider sliding under the menu on smaller screens#832

Merged
schtibe merged 2 commits intodevelopfrom
bug-pb-468-time-slider-underneath-menu
May 14, 2024
Merged

PB-468 Fixed Time-Slider sliding under the menu on smaller screens#832
schtibe merged 2 commits intodevelopfrom
bug-pb-468-time-slider-underneath-menu

Conversation

@schtibe
Copy link
Contributor

@schtibe schtibe commented May 13, 2024

The styling, which moved the Time Slider to the right, was on the wrong screen selectors, making it slide underneath the Menu on the left.

Fixed this by moving the styling to a lower screen size selector.

Test link

@github-actions github-actions bot added the bug label May 13, 2024
@schtibe schtibe force-pushed the bug-pb-468-time-slider-underneath-menu branch from ff14000 to 11f903b Compare May 13, 2024 14:33
@schtibe schtibe requested a review from ltshb May 13, 2024 14:40
@cypress
Copy link

cypress bot commented May 13, 2024

Passing run #2116 ↗︎

0 204 20 0 Flakiness 0

Details:

PB-468 Unify duplicate css selectors in time slider
Project: web-mapviewer Commit: b88fb25698
Status: Passed Duration: 04:42 💡
Started: May 14, 2024 8:15 AM Ended: May 14, 2024 8:20 AM

Review all test suite changes for PR #832 ↗︎

@schtibe schtibe force-pushed the bug-pb-468-time-slider-underneath-menu branch 2 times, most recently from 4876959 to bc9b50f Compare May 13, 2024 15:17
Copy link
Contributor

@ltkum ltkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

schtibe added 2 commits May 14, 2024 10:10
When the menu appears on desktop, the time slider has to move to the
right
@schtibe schtibe force-pushed the bug-pb-468-time-slider-underneath-menu branch from bc9b50f to b88fb25 Compare May 14, 2024 08:10
@schtibe schtibe merged commit ee763bd into develop May 14, 2024
@schtibe schtibe deleted the bug-pb-468-time-slider-underneath-menu branch May 14, 2024 08:21
@cypress cypress bot mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants