PB-481: bugfix apply transparency instead of opacity#827
Merged
Conversation
Passing run #2084 ↗︎
Details:
Review all test suite changes for PR #827 ↗︎ |
|||||||||||||||
ltshb
reviewed
May 13, 2024
src/modules/menu/components/activeLayers/MenuActiveLayersListItem.vue
Outdated
Show resolved
Hide resolved
src/modules/menu/components/activeLayers/MenuActiveLayersListItem.vue
Outdated
Show resolved
Hide resolved
fe5b07d to
c7486e4
Compare
f353a5c to
4aec6c8
Compare
ltshb
reviewed
May 13, 2024
tests/cypress/tests-e2e/layers.cy.js
Outdated
| cy.get(`[data-cy="slider-transparency-layer-${timedLayerId}-2"]`) | ||
| .should('be.visible') | ||
| .realClick() | ||
| .realClick({ position: 'right', force: true }) |
Contributor
There was a problem hiding this comment.
Force true is not a good idea why do you need it ?
Contributor
Author
There was a problem hiding this comment.
that's a leftover from when I was testing. I thought that maybe something was blocking the click. I'm removing it right now.
4aec6c8 to
46d94e5
Compare
Issue : On all labels for layers, we mention that we're modifying the transparency, when we are currently modifying the opacity. fix : we reverse the value on the transparency slider, committing `1 - value` to the layer's opacity rather than the value. still TODO : ensure tests work.
Changed the slider data-cy from 'opacity' to 'transparency' for consistency. with the new margin, one test had problems where clicking in the middle (0.5 opacity) was so close to the original value (0.7 opacity) that it wouldn't register the click to be on another position on the slide.
46d94e5 to
369a977
Compare
ltshb
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : On all labels for layers, we mention that we're modifying the transparency, when we are currently modifying the opacity.
fix : we reverse the value on the transparency slider, committing
1 - valueto the layer's opacity rather than the value.Test link