PB-447: legacy parser not switching to map view#825
Merged
Conversation
bd0a434 to
40fe1fb
Compare
Passing run #2226 ↗︎
Details:
Review all test suite changes for PR #825 ↗︎ |
|||||||||||||||
pakb
reviewed
May 8, 2024
| let routeChangeIsTriggeredByThisModule = false | ||
|
|
||
| // flag to tell us if we need to enforce a query redirection when coming from the legacy router | ||
| let needRouteChangeBecauseOfLegacy = true |
Contributor
There was a problem hiding this comment.
I'm not sure it's a good idea to set it to true by default.
Maybe it should be set to true the first time we enter the LegacyView. If I understand correctly the goal here is to make sure we exit this view, so it would make more sense this way (here I fear it will trigger something unwanted when entering the normal MapView...)
Contributor
Author
There was a problem hiding this comment.
That would make more sense. Functionally there is no real issue (the map view will go through the router one additional time, but it won't crash or go infinite), but it would be cleaner to only do it when we went through the legacy router first.
40fe1fb to
2156ed9
Compare
ltshb
reviewed
May 14, 2024
Contributor
ltshb
left a comment
There was a problem hiding this comment.
I'm not sure this is a good solution, looking at the code we should not have a problem, somehow we need to debug the vue router navigation guards
43cc43f to
308b33b
Compare
Issue : in some occasions, the router plugins would process the legacy query correctly, but not switch to the map view once it was done, staying stuck in the legacy view forever and not showing anything. This happened when there was no change to make to the query due to default parameters not being in the URL, but still needing a redirect to the map view. Fix : If we change the store and the view should change, we ask for a query change too
We need to be able to send the router to a 'next' route in some rare instances where the legacy parser was called, but there was no default parameter at all. To do this, we use an app parameter which is set to true by the legacy parser, and set to false the moment the store sync router makes a redirect. Also adding some debug logs
removing development logs moving logs where it makes sense to have them
13d419a to
e17b5e9
Compare
…egacy view PB-447: removing legacy Usage checker linting log level change
e17b5e9 to
4f97491
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : in some occasions, the router plugins would process the legacy query correctly, but not switch to the map view once it was done, staying stuck in the legacy view forever and not showing anything.
This happened when there was no change to make to the query due to default parameters not being in the URL, but still needing a redirect to the map view.
Fix : If we change the store and the view should change, we ask for a query change too
Test link