Conversation
The print scale on mobile was empty. This was due to the fact that we took the menu width in the computation for the scale. Now we don't take the menu width for the scale computation and we move the print center a bit down due to the header overlapping the map. Also did some renaming to make the code clearer
Passing run #2055 ↗︎
Details:
Review all test suite changes for PR #824 ↗︎ |
|||||||||||||||
pakb
reviewed
May 7, 2024
Contributor
pakb
left a comment
There was a problem hiding this comment.
Code looks good but I think you need to edit the print Cypress test to accommodate to your changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The print scale on mobile was empty. This was due to the fact that we took the menu width in the computation for the scale.
Now we don't take the menu width for the scale computation and we move the print center a bit down due to the header overlapping the map.
Also did some renaming to make the code clearer
Test link