PB-442: change timeslider css for partial data#823
Merged
Conversation
c1bf160 to
d7894b4
Compare
Passing run #2238 ↗︎
Details:
Review all test suite changes for PR #823 ↗︎ |
|||||||||||||||
d7894b4 to
320d059
Compare
ltshb
reviewed
May 14, 2024
Contributor
ltshb
left a comment
There was a problem hiding this comment.
Perso I would make the tippy simpler as currently
I would use kind of legend way having a list of square with the color and next to it the meaning.
393494e to
5ee6629
Compare
ltshb
reviewed
May 21, 2024
src/modules/i18n/locales/en.json
Outdated
| "time_hide": "Disable representation of data time stamps.", | ||
| "time_select_year": "Select a year", | ||
| "time_show": "Enable representation of data time stamps.", | ||
| "time_slider_legend_tippy_intro": "The time slider displays different colours depending on whether the time layers have data for the selected year or not.", |
Contributor
There was a problem hiding this comment.
In the UI we never talk about layer but about map so we should keep this nomenclature in help text.
The time slider displays different colors depending on whether the maps have data for the year or not.
For German and Italian, @hansmannj and @Luke252 can maybe help and also check english 😉 . For french a proposal that can be double check by you and @pakb
Le curseur de temps affiche différentes couleurs selon si les cartes temporelles disposent de données ou non.
There was a problem hiding this comment.
@ltshb I checked and compared the IT and EN versions with the rest. Hope it's clear ;)
Luke252
reviewed
May 21, 2024
Luke252
reviewed
May 21, 2024
Luke252
reviewed
May 21, 2024
Luke252
reviewed
May 21, 2024
Luke252
reviewed
May 21, 2024
Luke252
reviewed
May 21, 2024
Luke252
reviewed
May 21, 2024
Luke252
reviewed
May 21, 2024
Luke252
reviewed
May 21, 2024
Luke252
reviewed
May 21, 2024
Luke252
reviewed
May 21, 2024
Luke252
reviewed
May 21, 2024
Luke252
reviewed
May 21, 2024
hansmannj
reviewed
May 21, 2024
src/modules/i18n/locales/de.json
Outdated
| "drawing_attached": "Zeichnung als Anhang hinzugefügt" | ||
| "drawing_attached": "Zeichnung als Anhang hinzugefügt", | ||
| "switch_tooltip_attached_to_feature": "Tooltip an Geometrie anhängen", | ||
| "switch_tooltip_floating": "Eine schwebende Tooltip verwenden", |
hansmannj
reviewed
May 21, 2024
src/modules/i18n/locales/de.json
Outdated
Comment on lines
+682
to
+683
| "3d_vegetation_active": "Entferne Vegetationen", | ||
| "3d_vegetation_inactive": "Vegetationen hinzufügen", |
Member
There was a problem hiding this comment.
I'd use the singular "Vegetation" here in both cases
c99ab98 to
f2d2904
Compare
Member
|
Most of my comments are gone, I'll try to remember and re-write them 😉 |
hansmannj
reviewed
May 21, 2024
hansmannj
reviewed
May 21, 2024
91e4512 to
c9d2fe7
Compare
c9d2fe7 to
a3abf21
Compare
ltshb
approved these changes
May 22, 2024
Contributor
ltshb
left a comment
There was a problem hiding this comment.
I allowed myself to do some improvement on the tippy and rebased.
| placement: 'bottom', | ||
| delay: [1500, 500], | ||
| allowHTML: true, | ||
| followCursor: 'horizontal', |
Contributor
There was a problem hiding this comment.
After trying out, I find the folowCursor: 'initial' better here.
The striped bar was not satisfactory for conveying that there was only partial data available. Thus we now use a lighter shade of the primary color and added a tooltip to explain what the color means.
Part 1 : We fix the css here PB-442: update tippy translations
translation update
Tippy needs to be destroyed. Also avoid duplicate tippy content in code. For better readability use vue template for the complex tippy content. Fix margin issue with the play button introduced by `mx-1` class. Improve tippy content by adding some margin and padding.
a3abf21 to
0cee27f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We changed the color of the time slider bar when there is only partial data.
We also added a tippy on hovering the time slider bar, telling us which color is used for which state (no data, partial data, full data)
We also added a small correction to a german translation where a capitalized i shouldn't have been capitalized.
Test link with data
Test link