Conversation
Passing run #2076 ↗︎
Details:
Review all test suite changes for PR #819 ↗︎ |
|||||||||||||||
7826332 to
49235dc
Compare
49235dc to
34157c1
Compare
pakb
reviewed
May 7, 2024
src/utils/components/EmailInput.vue
Outdated
| class="mb-2" | ||
| :class="{ 'fw-bolder': required }" | ||
| :for="inputEmailId" | ||
| :data-cy="`${dataCyPrefix}-label`" |
Contributor
There was a problem hiding this comment.
It might be better (more comprehensible) to add static/fixed data-cy="..." here, and then add another one whenever the component is used
<EmailInput data-cy="some-identifier" />
It will be applied to the div wrapping the label and input, and we can still access them in Cypress test with cy.get('[data-cy="some-identifier"] [data-cy="..."]')
Contributor
Author
There was a problem hiding this comment.
Done, hopefully it was easy with search and replace, will see if the test passes 🤞🏼
Comment on lines
+28
to
+75
|
|
||
| export function useFieldValidation( | ||
| props, | ||
| model, | ||
| emits, | ||
| { | ||
| customValidate = () => { | ||
| return { valid: true, invalidMessage: '' } | ||
| }, | ||
| requiredInvalidMessage = 'field_required', | ||
| } = {} | ||
| ) { |
Contributor
There was a problem hiding this comment.
Could you add a bit of documentation that describe what inputs are expected and what they do?
fc6fb85 to
f11fba6
Compare
9bb39c1 to
0b06c83
Compare
They border are now identical to the input border.
Now forms are only validated after user action. This provide a better user feedback especially when the form has several fields, the form is only validated when the user click on the action button.
Based on @pakb review
866aeed to
23a66b1
Compare
pakb
approved these changes
May 8, 2024
the need-validation class was useless therefore I removed it. Also removed a useless html div. Be consistent in the css class of all input fields.
23a66b1 to
624e34a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now forms are only validated after user action. This provide a better user
feedback especially when the form has several fields, the form is only validated
when the user click on the action button.
This has been done for all forms:
Test link