Made the import tool maps provider search case insensitive#746
Merged
Made the import tool maps provider search case insensitive#746
Conversation
Sometimes due to data integration work, the topic tree can not be correctly loaded as a layer is added to the topic before it even exits on the BOD. Therefore on DEV in this case we print a warning instead of an error.
Passing run #1376 ↗︎
Details:
Review all test suite changes for PR #746 ↗︎ |
|||||||||||||||
pakb
approved these changes
Mar 28, 2024
Comment on lines
+54
to
+60
| if (ENVIRONMENT === 'development') { | ||
| log.warn( | ||
| `Child ${topicChild.id} can't be loaded, probably due to data integration work ongoing: ${err.message}` | ||
| ) | ||
| } else { | ||
| log.error(`Child ${topicChild.id} can't be loaded`, err) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link