Conversation
9e42fc3 to
e4cbc51
Compare
Passing run #1389 ↗︎
Details:
Review all test suite changes for PR #743 ↗︎ |
|||||||||||||||
5b36357 to
11459f1
Compare
ltshb
approved these changes
Mar 28, 2024
Contributor
ltshb
left a comment
There was a problem hiding this comment.
Just a minor improvement, thanks
Comment on lines
40
to
50
| watch(layer, async (newLayer) => { | ||
| htmlContent.value = await getLayerLegend(currentLang.value, newLayer.id) | ||
| htmlContent.value = await getLayerDescription(currentLang.value, newLayer.id) | ||
| }) | ||
|
|
||
| watch(layerId, async (newLayerId) => { | ||
| htmlContent.value = await getLayerLegend(currentLang.value, newLayerId) | ||
| htmlContent.value = await getLayerDescription(currentLang.value, newLayerId) | ||
| }) |
Contributor
There was a problem hiding this comment.
Here we should also check for non null value of newLayerId and for non external layer like in onMounted. Although it is not directly related to this PR, but it would be wise to change it, to improve the robustness of the code.
pakb
approved these changes
Mar 28, 2024
11459f1 to
438b26d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link