PB-325: Add styling to openlayers drag zoom#704
Merged
Conversation
Passing run #1112 ↗︎
Details:
Review all test suite changes for PR #704 ↗︎ |
|||||||||||||||
pakb
reviewed
Mar 14, 2024
| } | ||
| // Show selected area when shift click + drag on map | ||
| :global(.ol-dragzoom) { | ||
| border: 2px solid red; |
Contributor
There was a problem hiding this comment.
very "nitpicky" but could you use the SASS variable for red, so that we may change it later?
Either "$red" or "$primary" are fine (both can be imported by adding @import 'src/scss/webmapviewer-bootstrap-theme'; at the top of the <style> section, if not there already)
86860ca to
bf472f6
Compare
pakb
approved these changes
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link