Conversation
Passing run #1108 ↗︎
Details:
Review all test suite changes for PR #702 ↗︎ |
|||||||||||||||
pakb
approved these changes
Mar 14, 2024
Contributor
pakb
left a comment
There was a problem hiding this comment.
the redirect service has already been updated with this new rule?
| isLegacyUrl, | ||
| ...dispatcher, | ||
| }) | ||
| unRegisterRouterHook() |
Contributor
There was a problem hiding this comment.
What made it not working well keeping it under in the store subsribe?
Contributor
Author
There was a problem hiding this comment.
Nothing i just thought it would be wise to stop this plug-in sooner rather than later
The legacy embed view was at hostname/embed.html. Unfortunately we cannot reroute here to another path before the #, because the vue router using the createWebHashHistory can only handle route after the hash. Therefore we have an external redirect service that will redirect to /embed.html to ?legacyEmbed. We use this pseudo legacyEmbed to redirect to #/embed once the other legacy parameters have been translated.
d2bdcbd to
1236707
Compare
Contributor
Author
|
@pakb yes the redirect is ready and applied on dev see https://github.com/geoadmin/infra-kubernetes/pull/508 with this pr merge I’ll do some test before closing the ticket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy embed view was at hostname/embed.html. Unfortunately we cannot reroute
here to another path before the #, because the vue router using the createWebHashHistory
can only handle route after the hash. Therefore we have an external redirect
service that will redirect to /embed.html to ?legacyEmbed.
We use this pseudo legacyEmbed to redirect to #/embed once the other legacy
parameters have been translated.
NOTE: I first tried to set the redirect service directly to #/embed but then it made the startup procedure difficult as we needed to detect if other legacy parameters had to be translated and wait on them first. So for simplicity we use a legacy parameter as redirect
which simplify a lot the startup procedure which is then identical for other legacy parameters.
Test link