Conversation
Passing run #1088 ↗︎
Details:
Review all test suite changes for PR #698 ↗︎ |
|||||||||||||||
788abfd to
303f3e5
Compare
The goal here is to ensure all legacy parameters translate to their current counterparts. The tests do not have to be too thorough, as we are already testing those parameters in their current implementation.
PB-113: small correcton to WMS external legacy test remove comments
303f3e5 to
1e02cda
Compare
ltshb
reviewed
Mar 12, 2024
Comment on lines
+445
to
+448
| it('sets the language correctly', () => { | ||
| cy.goToMapView({ lang: 'it' }, false) | ||
| cy.readStoreValue('state.i18n.lang').should('eq', 'it') | ||
| }) |
Contributor
There was a problem hiding this comment.
Dito lang is not a legacy parameter and is already tested, we should remove it from here to keep the number of it() low
Comment on lines
+495
to
+497
| cy.readStoreValue('state.ui.width').then((width) => { | ||
| cy.wrap(slider.position()['left']).should('eq', width * 0.3 - 20) | ||
| }) |
Contributor
There was a problem hiding this comment.
Use .should((width)=>{}) construct instead with expect this ensure retries until the assertion is true
59dc5b6 to
667575a
Compare
…acy and current viewer remove cy call from the should callback removed no longer needed import
667575a to
87ead25
Compare
ltshb
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are adding tests for every official legacy parameter
Only missing now :
bod-layer-idandshowTooltipwhich are part of PB-190timewhich is not yet implemented and will be part of PB-307Test link