PB-316: Implemented correct map footer for /embed view#695
Merged
Conversation
8fb6b81 to
a8e44e1
Compare
a8e44e1 to
c2d14e3
Compare
Passing run #1006 ↗︎
Details:
Review all test suite changes for PR #695 ↗︎ |
|||||||||||||||
ltkum
approved these changes
Mar 7, 2024
Contributor
ltkum
left a comment
There was a problem hiding this comment.
Everything seems to be in order. The link you gave for the embed test link wasn't working (trailing slash after index.html). We are good to go in my opinion.
c253604 to
e3aecd5
Compare
8cfc095 to
144a3cb
Compare
144a3cb to
48c0092
Compare
48c0092 to
3758b84
Compare
The dispatcher constant is not available on the template.
…tead This make the code easier to understand and the footer is now constructed in the view, which allow different footer on different views.
3758b84 to
2c7dc5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link /embed
Test link /map
Test link