PB-341: Fix race condition in drawing e2e tests#693
Merged
Conversation
Passing run #946 ↗︎
Details:
Review all test suite changes for PR #693 ↗︎ |
|||||||||||||||
ca736c1 to
ca6857b
Compare
pakb
approved these changes
Mar 6, 2024
Apparently the debouncing of the feature title and description in drawing together with the save drawing debouncing creates a race condition when editing the title and/or description and closing the drawing mode. In this case the save kml triggered by the title/description update debounced happens only when the drawing mode is closed and when the drawing layer has removed all its feature which result to saving an empty drawing, clearing the existing drawing. To avoid this we speed up debouncing, this is not a perfect fix but it works and I could not find a way of correctly cleaning up the debouncing for the closing drawing menu event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently the debouncing of the feature title and description in drawing together
with the save drawing debouncing creates a race condition when editing the title
and/or description and closing the drawing mode. In this case the save kml
triggered by the title/description update debounced happens only when the
drawing mode is closed and when the drawing layer has removed all its
feature which result to saving an empty drawing, clearing the existing drawing.
To avoid this we speed up debouncing, this is not a perfect fix but it works
and I could not find a way of correctly cleaning up the debouncing for
the closing drawing menu event.
Test link