Merged
Conversation
Passing run #948 ↗︎
Details:
Review all test suite changes for PR #691 ↗︎ |
|||||||||||||||
5a77208 to
c6ded00
Compare
0968515 to
801bc4a
Compare
pakb
reviewed
Mar 6, 2024
| const props = defineProps({ | ||
| shareLinkUrlShorten: { | ||
| type: String, | ||
| type: [String, null], |
Contributor
There was a problem hiding this comment.
that seems counter-intuitive to have required: true and authorize null at the same time, maybe change that required: true to default: null (and make sure the code adapts well to a null value of this prop)
ltshb
approved these changes
Mar 6, 2024
612de1a to
9ae98c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link