Conversation
When exiting the drawing, we could have a race condition between the closing save and pending debounced save. Sometimes a pending debounce save, not started was started after the closing and closing save, which saved an empty kml because the drawing layer would have been removed. This was making some test failing time to time and could also have been an issue for a real user if he would close the drawing too quickly.
Passing run #915 ↗︎
Details:
Review all test suite changes for PR #690 ↗︎ |
|||||||||||||||
pakb
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When exiting the drawing, we could have a race condition between the closing
save and pending debounced save. Sometimes a pending debounce save, not started
was started after the closing and closing save, which saved an empty kml because
the drawing layer would have been removed.
This was making some test failing time to time and could also have been an
issue for a real user if he would close the drawing too quickly.
Test link