Conversation
Passing run #951 ↗︎
Details:
Review all test suite changes for PR #686 ↗︎ |
|||||||||||||||
b3ef835 to
9ae338a
Compare
9ae338a to
3763612
Compare
3763612 to
7a36f37
Compare
3763612 to
d96bc7c
Compare
d96bc7c to
3a1135a
Compare
Contributor
|
@LukasJoss @pakb I think I've found the issue with the flaky test, the issue is due to the save drawing debouncing that is started when adding a feature and the close drawing. It seems to me that the debouncing save happens once the menu is closed and therefore save an empty drawing which replace the layer. I'll add a fix to this PR and let you know for the review. I think this issue has actually nothing to do with the changes of this PR but is a pre-existing race condition. |
679ea63 to
bc0e351
Compare
bc0e351 to
c3975eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link