PB-74: Infobox tooltip aera info improvement#684
Merged
Conversation
Passing run #987 ↗︎
Details:
Review all test suite changes for PR #684 ↗︎ |
|||||||||||||||
1f0cd18 to
307e3b9
Compare
307e3b9 to
f4cfe2f
Compare
c84ff46 to
1843228
Compare
ltshb
reviewed
Mar 7, 2024
|
|
||
| const props = defineProps({ | ||
| feature: { | ||
| type: EditableFeature, |
Contributor
There was a problem hiding this comment.
This should be of SelectableFeature type no EditableFeature
Comment on lines
+55
to
+56
| border: 2px solid black; | ||
| background-color: #999; |
Contributor
There was a problem hiding this comment.
Perso I would not add a border and use another background grey, at best use a bootstrap gray, e.g. gray-300 like for the list item hover. Maybe try to also add a small corner rounding.
| { | ||
| title: 'profile_distance', | ||
| icons: [ | ||
| ['far', 'eye'], |
Contributor
There was a problem hiding this comment.
The icon eye should also be removed from the setup-fontawesome list if not used anymore
| </span> | ||
| <span v-else-if="info.type === 'Polygon'" class="compact-measures-half"> | ||
| <FontAwesomeIcon :icon="['far', 'square']" /> {{ info.perimeter }}<br /> | ||
| <FontAwesomeIcon :icon="['fas', 'square-full']" /> |
Contributor
There was a problem hiding this comment.
Dito remove the square-full icon from the setup
ltshb
approved these changes
Mar 7, 2024
Contributor
ltshb
left a comment
There was a problem hiding this comment.
All good just one minor improvement
Comment on lines
+23
to
+27
| if (calculatedArea > 10000) { | ||
| result += 'km' | ||
| } else { | ||
| result += 'm' | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe add a space before km and m
3abe5ca to
ff5b826
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link