PB-190: Refactor Infobox Module for Composition API#683
Merged
Conversation
This is a 1 to 1 rewrite of the infobox module, switching it to composition API. Since we're going to change some logical lines within this file, it stands to reason to change it. The 'scrollTo' doesn't seem to work, but it's the same as in the current implementation.
Passing run #864 ↗︎
Details:
Review all test suite changes for PR #683 ↗︎ |
|||||||||||||||
ltshb
approved these changes
Mar 5, 2024
Contributor
ltshb
left a comment
There was a problem hiding this comment.
All good. While testing I've find a small bug, the cursor is set to pointer on the infobox header (see line 162), it should only be pointer when hovering the header buttons but not the bar, would be nice to also quickly fix this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a preliminary work for the showtooltip implementation, we have refactored the Infobox Module to the composition API.
Test link