PB-102: Fix legacy external layers with coma in layer tilte#681
Merged
PB-102: Fix legacy external layers with coma in layer tilte#681
Conversation
Passing run #852 ↗︎
Details:
Review all test suite changes for PR #681 ↗︎ |
|||||||||||||||
8f844f5 to
2d1cdf6
Compare
In the legacy viewer the layer title was part of the URL and some layer could contain a coma in its title which broke the layers parsing as the layers in URL are separated by coma.
In the WMS we can add a group of layer form the base of the capabilities.
Legacy external WMS layer name could contain comma, therefore added a comma to the unit tests. On the other hand new url don't contains anymore the layer name in the url. Also the legacy WMTS url did not contain the layer name therefore remove it from the test
2d1cdf6 to
770fdb4
Compare
The base layer was not parsed, so added a unit test to cover this.
770fdb4 to
04d0ec7
Compare
ltkum
approved these changes
Mar 4, 2024
Contributor
ltkum
left a comment
There was a problem hiding this comment.
Took the time to test it quickly, and it looks like it's working fine. Good work 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the legacy viewer the layer title was part of the URL and some layer
could contain a coma in its title which broke the layers parsing as the layers
in URL are separated by coma.
Test link