upgrade to OL v9.0.0 and update other libs#679
Merged
Conversation
Passing run #898 ↗︎
Details:
Review all test suite changes for PR #679 ↗︎ |
|||||||||||||||
Contributor
Author
|
Cypress forgot to run 99% of our tests, I'll check on Monday what has changed in the config between the two minor versions |
1ad8e6e to
2418a1c
Compare
Contributor
Author
|
The issue was that some typescript type check we not valid anymore with the newer OL 9 and our shallow copy of ol-cesium |
ltshb
reviewed
Mar 6, 2024
ltshb
approved these changes
Mar 6, 2024
Contributor
ltshb
left a comment
There was a problem hiding this comment.
Did some manual tests and it looks good
OpenLayers 9.0.0 => deleting our temporary own copy of ol/format/GPX that we amended on the repo itself
by adding a couple wait, trying to mitigate race conditions (CI failed because no feature were loaded) and removing unnecessary :visible (.click will already check that it is visible)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenLayers 9.0.0 => deleting our temporary own copy of ol/format/GPX that we amended on the repo itself
Test link