PB-259: Manual chunks for better startup performance#675
Merged
Conversation
11c1eff to
cdb1f51
Compare
Passing run #856 ↗︎
Details:
Review all test suite changes for PR #675 ↗︎ |
|||||||||||||||
ad02d61 to
23e7b84
Compare
23e7b84 to
e89754c
Compare
e9986a7 to
1b1754b
Compare
pakb
approved these changes
Mar 4, 2024
1b1754b to
3f5c5b4
Compare
When loading the menu as async componenent, it adds a kind of race condition when toggling in 3d mode for the first time making the application crash. So avoid this race condition by keeping the menu module within the index chunk. NOTE: I did not track down the race condition to understand what was really the issue.PB.2559: Fix toggling in 3d race condition
3f5c5b4 to
d6bc952
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
Test link