PB-190 : Implement feature pre selection#674
Merged
Conversation
Passing run #999 ↗︎
Details:
Review all test suite changes for PR #674 ↗︎ |
|||||||||||||||
Contributor
|
The parsing is fine and works well, but I think you should add a zoomToExtent to the feature's extent (or at least zoom closer if there's no extent available). The goal is to show the feature "in isolation" while using an iframe |
296ebef to
fa63372
Compare
pakb
reviewed
Mar 8, 2024
We added an additional possible custom parameter which allows to select
features which IDS are known from the URL, like the old {bod-layer-id}
parameter.
…override the currently set zoom
moved the extent calculation from feature.api.js to geoJsonUtils.js using turf. Handling async calls in a better way Small simplification of tests
ff4e07d to
f069994
Compare
pakb
reviewed
Mar 8, 2024
pakb
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added an additional possible custom parameter which allows to select features which IDS are known from the URL, like the old {bod-layer-id} parameter.
Test link