Skip to content

PB-56: Added other 3D constructions#667

Merged
rebert merged 2 commits intodevelopfrom
feat-PB-270-add-3D-constructions
Feb 28, 2024
Merged

PB-56: Added other 3D constructions#667
rebert merged 2 commits intodevelopfrom
feat-PB-270-add-3D-constructions

Conversation

@rebert
Copy link
Contributor

@rebert rebert commented Feb 28, 2024

@rebert rebert requested review from ltshb and pakb February 28, 2024 10:05
@cypress
Copy link

cypress bot commented Feb 28, 2024

Passing run #791 ↗︎

0 168 21 0 Flakiness 0

Details:

PB-300: satisfying lint
Project: web-mapviewer Commit: f7a96d2e87
Status: Passed Duration: 03:50 💡
Started: Feb 28, 2024 3:46 PM Ended: Feb 28, 2024 3:50 PM

Review all test suite changes for PR #667 ↗︎

@pakb
Copy link
Contributor

pakb commented Feb 28, 2024

You might need to adjust a couple "magic numbers" in tests, where it was assumed that there was X number of primitive layers (as you just added a new one)

@rebert rebert force-pushed the feat-PB-270-add-3D-constructions branch 14 times, most recently from 7423562 to ae0dde5 Compare February 28, 2024 15:25
@rebert rebert force-pushed the feat-PB-270-add-3D-constructions branch from ae0dde5 to fe7bbf3 Compare February 28, 2024 15:33
@rebert rebert merged commit 00fe330 into develop Feb 28, 2024
@rebert rebert deleted the feat-PB-270-add-3D-constructions branch February 28, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants