Conversation
Passing run #817 ↗︎
Details:
Review all test suite changes for PR #666 ↗︎ |
|||||||||||||||
2a69e98 to
e36ae87
Compare
pakb
approved these changes
Feb 29, 2024
e36ae87 to
a6798fa
Compare
This will ease the startup procedure for other views. It also slightly improve startup performance.
The command could wait to the wrong number of layers, the topic target should only be taken into account when no layer parameter is given.
This view is necessary to parse the parameter of the legacy parameter only when the config is ready and we can also use it in future to display a warning message.
This url param is currently not implemented properly, see PB-295, and this test is wrong anyway.
a6798fa to
ec72630
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will ease the startup procedure for other views. It also slightly improve
startup performance.
Test link