Skip to content

PB-259: Improve startup performance by postponing the topic tree rendering#661

Closed
ltshb wants to merge 4 commits intodevelopfrom
feat-PB-259-performance-menu
Closed

PB-259: Improve startup performance by postponing the topic tree rendering#661
ltshb wants to merge 4 commits intodevelopfrom
feat-PB-259-performance-menu

Conversation

@ltshb
Copy link
Contributor

@ltshb ltshb commented Feb 26, 2024 •
edited by github-actions bot
Loading

@ltshb ltshb changed the base branch from feat-PB-259-performance-router to feat-PB-259-legacy February 26, 2024 15:02
@cypress
Copy link

cypress bot commented Feb 26, 2024 •
edited
Loading

88 failed tests on run #757 ↗︎

88 52 21 28 Flakiness 0

Details:

wip
Project: web-mapviewer Commit: 64fa69f38e
Status: Failed Duration: 08:26 💡
Started: Feb 28, 2024 6:04 AM Ended: Feb 28, 2024 6:12 AM
Failed  layers.cy.js • 15 failed tests • e2e/electron/mobile

View Output

Test Artifacts
... > reads and adds an external WMS correctly Test Replay Screenshots
... > reads and adds an external WMTS correctly Test Replay Screenshots
... > handles errors correctly Test Replay Screenshots
... > shows active layers in the menu Test Replay Screenshots
... > removes a layer from the visible layers when the "remove" button is pressed Test Replay Screenshots
... > shows a hyphen when no layer is selected Test Replay Screenshots
... > shows no hyphen when a layer is selected Test Replay Screenshots
... > add layer from topic (should be visible) Test Replay Screenshots
... > add layer from search bar Test Replay Screenshots
... > allows toggling layers visibility from the topic menu Test Replay Screenshots
The first 10 failed tests are shown, see all 15 tests in Cypress Cloud.
Failed  drawing.cy.js • 11 failed tests • e2e/electron/mobile

View Output

Test Artifacts
Drawing module tests > Drawing mode/tools > can create marker/icons and edit them Test Replay Screenshots
Drawing module tests > KML management > deletes the drawing when confirming the delete modal Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer in the layer list / URL params correctly Test Replay Screenshots
Drawing module tests > KML management > keeps the KML after a page reload, and creates a copy if it is then edited Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup from a legacy URL Test Replay Screenshots
Drawing module tests > others > doesn't save an empty drawing (if not modified) Test Replay Screenshots
Drawing module tests > others > can export the drawing/profile in multiple formats Test Replay Screenshots
Drawing module tests > others > generates short links when sharing a drawing Test Replay Screenshots
Drawing module tests > others > shows a profile of a line/measure coming from service-alti data Test Replay Screenshots
The first 10 failed tests are shown, see all 11 tests in Cypress Cloud.
Failed  importToolFile.cy.js • 3 failed tests • e2e/electron/mobile

View Output

Test Artifacts
The Import File Tool > Import KML file Test Replay Screenshots
The Import File Tool > Import KML file error handling Test Replay Screenshots
The Import File Tool > Import GPX file Test Replay Screenshots
Failed  feedback.cy.js • 4 failed tests • e2e/electron/mobile

View Output

Test Artifacts
Testing the feedback form > Feedback button placement > should be in the configuration section of the menu on mobile Test Replay Screenshots
Testing the feedback form > Feedback button placement > should be in the header as a link on desktop Test Replay Screenshots
Testing the feedback form > From validation > is not possible to send a feedback without a rating Test Replay Screenshots
... > generates a complete request to service-feedback Test Replay Screenshots
Failed  shareShortLink.cy.js • 1 failed test • e2e/electron/mobile

View Output

Test Artifacts
Testing the share menu > Short link generation > Does not generate a short link at startup Test Replay Screenshots

The first 5 failed specs are shown, see all 21 specs in Cypress Cloud.

Review all test suite changes for PR #661 ↗︎

Base automatically changed from feat-PB-259-legacy to feat-PB-259-performance-router February 27, 2024 08:02
@ltshb ltshb force-pushed the feat-PB-259-performance-router branch from fdcdf6a to f1ed1ba Compare February 27, 2024 12:29
Base automatically changed from feat-PB-259-performance-router to develop February 27, 2024 12:40
@ltshb ltshb force-pushed the feat-PB-259-performance-menu branch from 392cf5b to 64fa69f Compare February 28, 2024 06:01
@ltshb ltshb mentioned this pull request Feb 28, 2024
Merged
@ltshb
Copy link
Contributor Author

ltshb commented Feb 28, 2024

This PR is replaced by #663

@ltshb ltshb closed this Feb 28, 2024
@pakb pakb deleted the feat-PB-259-performance-menu branch March 20, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ltshb