PB-259: Added dispatcher to all store events#659
Merged
Conversation
Passing run #739 ↗︎
Details:
Review all test suite changes for PR #659 ↗︎ |
|||||||||||||||
pakb
reviewed
Feb 26, 2024
Contributor
pakb
left a comment
There was a problem hiding this comment.
I haven't checked if there're still uses with e.g. MyComponent/sub-category. If there is, I think we should edit those and move to a unique const at the top of the file, without specifying the sub-category (so long as you don't see counter points to this)
3b94003 to
368e114
Compare
368e114 to
d6aba75
Compare
pakb
approved these changes
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link