Merged
Conversation
Passing run #716 ↗︎
Details:
Review all test suite changes for PR #657 ↗︎ |
|||||||||||||||
ltshb
approved these changes
Feb 26, 2024
Contributor
ltshb
left a comment
There was a problem hiding this comment.
Nice thanks, just a minor improvement in cypress test to do.
Comment on lines
+143
to
+146
| it('opens a whatsapp popup with the short link as content', () => { | ||
| checkSocialNetworkType( | ||
| 'whatsapp', | ||
| `https://api.whatsapp.com/send?text=%0D%0A${encodeURIComponent(dummyShortLink)}` | ||
| ) | ||
| }) |
Contributor
There was a problem hiding this comment.
Cypress it() are quite costly in test performance and cost (if we would have a non open source software it would cost), so now we tend to do less it(), I would suggest instead of adding a new it() (test case) to merge all in it() of the social network context into one it(). Each part of the test should be separate by a cy.log() statement to ease debugging (e.g. cy.log('opens a whatsapp popup ....')
b72353e to
a69c647
Compare
ff1dc01 to
9d17786
Compare
9d17786 to
6f8aa41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link