PB-293: Corrected external layer order at startup and improve a bit performance#652
Merged
PB-293: Corrected external layer order at startup and improve a bit performance#652
Conversation
457189d to
b56dd0e
Compare
Passing run #678 ↗︎
Details:
Review all test suite changes for PR #652 ↗︎ |
|||||||||||||||
3ac2f5c to
5ca0a04
Compare
…erformance The external layers were always put at the top during startup even if they were in the middle of the layers parameter.
5ca0a04 to
1dff096
Compare
Changed the order of the expected query parameter in legacy test. In external wmts layer, somehow the Get capabilites are called twice at startup which made the test failing because the second wait on capabilities when reloading did not wait due to previous request. In a separate PR we should investigate why the get capabilities is called twice.
pakb
approved these changes
Feb 22, 2024
Comment on lines
+18
to
+23
| if (layer.visible != undefined) { | ||
| clone.visible = layer.visible | ||
| } | ||
| if (layer.opacity != undefined) { | ||
| clone.opacity = layer.opacity | ||
| } |
Contributor
Author
There was a problem hiding this comment.
No I want != in order to also catch !== null 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The external layers were always put at the top during startup even if they
were in the middle of the layers parameter.
Test link