Conversation
adding it anyway, the UI to edit its value won't be added to the app on PROD
Fix error on prod when debug store module is absent
pakb
approved these changes
Feb 21, 2024
Passing run #665 ↗︎Details:
Review all test suite changes for PR #651 ↗︎ |
|||||||||||||||
according to Vite documentation and a quick search on this, it is required to have the SCSS file be named .module.scss so that Vite can handle it correctly to pass things to JS
Simplifying a bit style function, as points can also have a fill (it won't change the look and feel) I've used two colors defined in our SCSS as starting point for the highlighting colors, and use a tool that "spread" the colors to chose the two middle points (also making sure it is color blind safe)
instead of adding a border around the feature detail, we now change the whole feature detail's background color to signify it is highlighted
…d_feature PB-123 : Change color of hovered feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link