Skip to content

New Release v1.6.0 - #minor#651

Merged
ltshb merged 8 commits intomasterfrom
develop
Feb 21, 2024
Merged

New Release v1.6.0 - #minor#651
ltshb merged 8 commits intomasterfrom
develop

Conversation

@ltshb
Copy link
Contributor

@ltshb ltshb commented Feb 21, 2024

pakb and others added 2 commits February 21, 2024 14:25
adding it anyway, the UI to edit its value won't be added to the app on PROD
Fix error on prod when debug store module is absent
@ltshb ltshb requested a review from pakb February 21, 2024 13:33
@github-actions github-actions bot changed the title re New Release v1.6.0 - #minor Feb 21, 2024
@cypress
Copy link

cypress bot commented Feb 21, 2024

Passing run #665 ↗︎

0 176 21 0 Flakiness 0

Details:

Merge pull request #639 from geoadmin/feat_PB-123_change_color_hovered_feature
Project: web-mapviewer Commit: 3b5b191479
Status: Passed Duration: 06:10 💡
Started: Feb 21, 2024 1:54 PM Ended: Feb 21, 2024 2:00 PM

Review all test suite changes for PR #651 ↗︎

pakb added 6 commits February 21, 2024 14:43
according to Vite documentation and a quick search on this, it is required to have the SCSS file be named .module.scss so that Vite can handle it correctly to pass things to JS
Simplifying a bit style function, as points can also have a fill (it won't change the look and feel)

I've used two colors defined in our SCSS as starting point for the highlighting colors, and use a tool that "spread" the colors to chose the two middle points (also making sure it is color blind safe)
instead of adding a border around the feature detail, we now change the whole feature detail's background color to signify it is highlighted
…d_feature

PB-123 : Change color of hovered feature
@ltshb ltshb merged commit a5e37c8 into master Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants