PB-100: Manage camera and 3D parameter from the legacy parameters#607
Merged
ismailsunni merged 7 commits intodevelopfrom Jan 19, 2024
Merged
PB-100: Manage camera and 3D parameter from the legacy parameters#607ismailsunni merged 7 commits intodevelopfrom
ismailsunni merged 7 commits intodevelopfrom
Conversation
Passing run #302 ↗︎
Details:
Review all test suite changes for PR #607 ↗︎ |
|||||||||||||||
Contributor
|
@ismailsunni thanks for the PR, could you add the |
5c7d0be to
1ba745a
Compare
Contributor
Author
|
@ltshb done |
ltshb
approved these changes
Jan 18, 2024
Contributor
ltshb
left a comment
There was a problem hiding this comment.
Looks good to me just a small typo
| newQuery['3d'] = true | ||
| newQuery['sr'] = WEBMERCATOR.epsgNumber | ||
|
|
||
| // Handle different backrgound layer from legacy 3D parameter |
Contributor
|
@ismailsunni please not to not merge develop into your branch but rebase your branch on top of develop in order to keep a clean git history, thanks |
pakb
approved these changes
Jan 18, 2024
tests/cypress/support/commands.js
Outdated
| ) | ||
| if ('3d' in queryParams && queryParams['3d'] === true) { | ||
|
|
||
| // In the legacy URL, 3d is not found. We check is the map in 3d or not by checking the pitch, heading, and elevation |
Contributor
There was a problem hiding this comment.
another minor typo here We check if the map... and not We check is the map...
1ba745a to
1971af6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transferring legacy parameters for 3D maps including:
lon,lat,elevation,pitch,headinginto camera position3dto truesrto WEBMERCATORbgLayerto use the 3D oneExample of old geoadmin: https://map.geo.admin.ch/?lang=en&topic=ech&bgLayer=ch.swisstopo.pixelkarte-farbe&layers=ch.swisstopo.zeitreihen,ch.bfs.gebaeude_wohnungs_register,ch.bav.haltestellen-oev,ch.swisstopo.swisstlm3d-wanderwege,ch.swisstopo.swissnames3d&layers_visibility=false,false,false,true,false&layers_timestamp=18641231,,,,&layers_opacity=1,1,1,0.8,1&lon=10.14968&lat=45.51136&elevation=215370&heading=317.946&pitch=-45.394
Example of new geoadmin with old parameter: https://sys-map.dev.bgdi.ch/preview/feat-pb-100-manage-3d-parameters/index.html?lang=en&topic=ech&bgLayer=ch.swisstopo.pixelkarte-farbe&layers=ch.swisstopo.zeitreihen,ch.bfs.gebaeude_wohnungs_register,ch.bav.haltestellen-oev,ch.swisstopo.swisstlm3d-wanderwege,ch.swisstopo.swissnames3d&layers_visibility=false,false,false,true,false&layers_timestamp=18641231,,,,&layers_opacity=1,1,1,0.8,1&lon=10.14968&lat=45.51136&elevation=215370&heading=317.946&pitch=-45.394
Test link