Merged
Conversation
…data This has been found while debugging e2e tests where the request intercept to the profile is done without data, it crash the application. Handle correctly such case when the api backend would malfunction to avoid any crash of the application.
ae738d2 to
5b44604
Compare
pakb
approved these changes
Oct 24, 2023
In this one the projection was not correctly passed downward.
5b44604 to
2f6f459
Compare
Now the coordinates from the service-alti api are rounded at two digits, therefore update the csv mocking in order to have the correct output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed crash when api.profile answer doesn't contain data
This has been found while debugging e2e tests where the request intercept
to the profile is done without data, it crash the application.
Handle correctly such case when the api backend would malfunction to avoid
any crash of the application.
Avoid crash in FeatureCombo component In this one the projection was not correctly passed downward.
Test link