BGDIINF_SB-2890: Fixed elevation profile tracking in lv95#477
Merged
ltshb merged 5 commits intodevelop-lv95from Oct 23, 2023
Merged
BGDIINF_SB-2890: Fixed elevation profile tracking in lv95#477ltshb merged 5 commits intodevelop-lv95from
ltshb merged 5 commits intodevelop-lv95from
Conversation
d5127c3 to
b62e9d0
Compare
b62e9d0 to
a132aaf
Compare
a132aaf to
d7a9889
Compare
pakb
approved these changes
Oct 23, 2023
Contributor
pakb
left a comment
There was a problem hiding this comment.
Minor details, and the comment on what we've talked about in our last call, and we are good to go! Thanks!
d7a9889 to
8875bde
Compare
This might introduce subtle bugs where we forgot to pass the correct projection. Better to make it mandatory and let the application crash with a backtrace when it is missing.
…the correct projection So there is no need to change it in componenent.
Made the geodesic component projection aware instead of hardcoding it to Web Mercator. This solve the bug when hovering the elevation profile the position was not tracked on the map.
…file During the drawing of the profile we need to sketch the point of the mouse. For this we did a wrap X coordinates, I don't know the reason why and it appears that it is not needed as open layer can handle both coordinates (wrapped and non wrapped), because this coordinate is only a temporary coordinate I think that is why it is not needed. Because to correctly wrap a coordinate you need to know in which projection you are and that in this event type you don't know it, I removed the wrap x for simplicity.
8875bde to
4bc121e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the profile tracking when hovering the profile, the point is tracked on the map. This has been brocken when passing to lv95.
Test link