BGDIINF_SB-2501 : add support for embed URL param#407
Conversation
when set to true, the UI is simplified to a minimum (zoom in zoom out and a link to open the app in a new tab) I had to rework a bit the URL parsing tooling for this, as otherwise the embed=false or embed= were staying in the URL. But working on this opened another whole can of worms with app startup and I had to change the logic in some places in the storeSync plugin to fix that (layers and bgLayers were disappearing at startup somehow)
|
@pakb Would it not be better to also allow |
|
@pakb switching infobox of a feature to the header don't work, the infobox disappear and the user need to refresh the windows to see it again. |
|
@pakb After some thoughts if we need to touch the URL parameter logics, I think it would be wise to try to simplify it. It seems a bit complex to me especially with the
This should allow to have the |
Insead of choosing between keeping an empty value in the URL or not, we now can define which is the default value of a param, and if it should stay in the URL when the value in the store is the default value.
92be64b to
a977700
Compare
|
Should be as you have suggested, I've modified the URL param parser so that flags can be set to true just by being present in the URL (no need to |
|
@pakb I guess the old embed (old viewer) translation to the new viewer will be done via redirect ? embedeed.html -> #?embed, am I correct. Has it already be done ? If not is there already a ticket ? |
that's a good point, as it was a different HTML endpoint in mf-geoadmin3 I think we might need to tackle that on the proxy/redirect side of things (what Bernie was working on recently), I'll create a ticket so that we do not forget to deal with it. |
when set to true, the UI is simplified to a minimum (zoom in zoom out and a link to open the app in a new tab)
I had to rework a bit the URL parsing tooling for this, as otherwise the embed=false or embed= were staying in the URL. But working on this opened another whole can of worms with app startup and I had to change the logic in some places in the storeSync plugin to fix that (layers and bgLayers were disappearing at startup somehow)
Test link