Skip to content

BGDIINF_SB-2609: consistent rounding#405

Merged
pakb merged 1 commit intodevelopfrom
BGDIINF_SB-2609-round-position
May 3, 2023
Merged

BGDIINF_SB-2609: consistent rounding#405
pakb merged 1 commit intodevelopfrom
BGDIINF_SB-2609-round-position

Conversation

@ltkum
Copy link
Contributor

@ltkum ltkum commented Apr 27, 2023

Issue : When displaying longitude and latitude, when the last figure of a number was 0, we would display numbers with a different significant number after the decimal.

Fix : We now use the "toFixed" native js function to have a fixed amount of significant numbers after the decimal.

Test link

@ltkum ltkum requested a review from pakb April 27, 2023 08:29
@ltkum ltkum force-pushed the BGDIINF_SB-2609-round-position branch 4 times, most recently from d07a10c to 1feb7a3 Compare April 28, 2023 08:24
@ltkum ltkum force-pushed the BGDIINF_SB-2609-round-position branch 2 times, most recently from e671e8f to 77f93c2 Compare May 2, 2023 08:01
Issue : When displaying longitude and latitude, when the last figure of
a number was 0, we would display numbers with a different significant
number after the decimal.

Fix : We now use the "toFixed" native js function to have a fixed amount
of significant numbers after the decimal.

remove import that shouldn't be here

only calling the fixed numbers in the appropriate cases

adding rounding for all float coordinates

linting
@ltkum ltkum force-pushed the BGDIINF_SB-2609-round-position branch from 77f93c2 to f7e1fca Compare May 2, 2023 08:04
@pakb pakb merged commit d5b382e into develop May 3, 2023
@pakb pakb deleted the BGDIINF_SB-2609-round-position branch May 3, 2023 06:19
@pakb pakb mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants