Merged
Conversation
4f0b4cd to
618894a
Compare
Issue : Some layers have no legend, and upon clicking the legend button, the legend popup shows up and looks like it's perpetually loading content. Fix : We added a `hasLegend` getter in the abstractLayer class, which is then called to decide wheter we show the legend button or not. Currently, we consider KML and external layers has having no legend. A refinement might be needed further down in the line to ensure layers with legends show the legend icon, but this is sufficient for now. importing layertypes remove logs
pakb
approved these changes
May 1, 2023
Comment on lines
+183
to
+186
| if (this.layer !== null) { | ||
| return this.layer.hasLegend | ||
| } | ||
| return false |
Contributor
There was a problem hiding this comment.
just for curiosity, you can "one line" this in JS with the optional chaining :
return this.layer?.hasLegend
with this notation, hasLegend will only be accessed if this.layer is valid (not null or undefined), otherwise it returns null (and as null is somewhat equivalent to false in JS, that works pretty well)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : Some layers have no legend, and upon clicking the legend button, the legend popup shows up and looks like it's perpetually loading content.
Fix : We added a
hasLegendgetter in the abstractLayer class, which is then called to decide wheter we show the legend button or not.Currently, we consider KML and external layers has having no legend. A refinement might be needed further down in the line to ensure layers with legends show the legend icon, but this is sufficient for now.
Test link