BGDIINF_SB-2829: Text in tooltips is now selectable#396
Merged
Conversation
ltshb
reviewed
Mar 27, 2023
Contributor
ltshb
left a comment
There was a problem hiding this comment.
Looks good but I don't understand why it did not work before, was it because of the map-popover-overlay class ? Where is this class defined ? Looking at the code diff I would have expect that the text selection of the location popup is removed ! So maybe better explain the code changes in commit.
Text in the tooltips of features was previously not selectable. This commit fixes this. The classname map-popover-overlay did not exist. Removing this classname activates instead the default class name ol-selectable and ol-overlay-container which makes the text in the overlay selectable. (The overlay is a child of the openlayersmap which deactivates selection)
f50f8cb to
85c43ad
Compare
Contributor
Author
I changed the commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text in the tooltips of features was previously not selectable. This
commit fixes this. The classname map-popover-overlay did not exist.
Removing this classname activates instead the default class name
ol-selectable and ol-overlay-container which makes the text in the
overlay selectable. (The overlay is a child of the openlayersmap which
deactivates selection)
Test link