Conversation
ltshb
left a comment
There was a problem hiding this comment.
Change the title to match the bug that we fix, e.g. similar to the ticket title. For release note it is not clear why the menu is above infobox in phone mode.
Also when testing on desktop if the tooltip is in the map overlay it is behind the menu, but if it is set below it is on top of menu also blocking the menu interaction ! You cannot close the menu anymore ! I think this should be also fixed for desktop.
|
@ltshb For desktop we should maybe first discuss how we want to fix it because I do not see an obvious solution. Possible solutions:
|
I added a more accurate description at the top to explain the changes and tried to change title to something a bit more understandable. However, the original ticket title is not an accurate description, as technically scrolling was still possible. It's just that a part of the menu was hidden by the popup. |
ltshb
left a comment
There was a problem hiding this comment.
ok as discussed in refinement meeting
pakb
left a comment
There was a problem hiding this comment.
As discussed together in refinement, this is a good enough solution and we will move on with this for the time being.
A future improvement would be to take the footer/infobox height into account when setting the height of the menu, but that requires extensive work (either render the infobox as pure CSS, and then adapt the placement with some CSS grid magic, or add the infobox height as Javascript computation in the menu height management)
We will wait for further negative feedback on this issue before spending any time on this complex topic
0fbfb42 to
4925c25
Compare
It makes sense for the menu to be above the infobox in phone mode. In desktop mode, we leave it as is for now.
4925c25 to
300972b
Compare
It makes sense for the menu to be above the infobox in phone mode, as in phone mode the menu is fullscreen and so opens on top of everything else. In desktop mode on the contrary, the menu is open most of the time so a user should never be forced to close the menu just to see a popup. Thats why we leave the popup on top of the menu in desktop mode.
Test link